Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismemberment hotfix #12080

Merged
merged 11 commits into from
Dec 26, 2024
Merged

Conversation

Rukofamicom
Copy link
Contributor

About The Pull Request

This prevents chest dismemberment right alongside head dismemberment for the same reasons - unlike losing a limb which is a very substantial disadvantage, losing your head or internal organs is an immediate loss with almost no chance of survival. I didn't realize chests could be dismembered because they aren't actually - but organs being spilled out is apparently what dismembering a chest does and the previous PR made this possible with certain weapons in a single hit.

Why It's Good For The Game

Instantly losing, even on a chance, isn't comparable to immediately losing a hand/leg and should only be possible if the player is already in crit or dead, just like the logic already in place for decapitation.

Testing Photographs and Procedure

image

Changelog

🆑
fix: Fixed an oversight in the dismemberment PR that allowed players to be disembowled in a single hit. Players will need to be at least unconscious or in crit before disembowling may occur.
/:cl:

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@XeonMations
Copy link
Contributor

LGTM 👍

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Dec 26, 2024
Merged via the queue into BeeStation:master with commit 891acfb Dec 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants